chia7712 commented on code in PR #20865:
URL: https://github.com/apache/kafka/pull/20865#discussion_r2522454095
##########
tools/src/main/java/org/apache/kafka/tools/TopicCommand.java:
##########
@@ -751,8 +751,7 @@ public TopicCommandOptions(String[] args) {
KAFKA_CONFIGS_CLI_SUPPORTS_ALTERING_TOPIC_CONFIGS);
describeOpt = parser.accepts("describe", "List details for the
given topics.");
topicOpt = parser.accepts("topic", "The topic to create, alter,
describe or delete. It also accepts a regular " +
- "expression, except for --create option. Put topic
name in double quotes and use the '\\' prefix " +
- "to escape regular expression symbols; e.g.
\"test\\.topic\".")
+ "expression, except for --create option. Put topic
name in double quotes; e.g. \"test.*\".")
Review Comment:
> It really would be nicer if this tool had separate options for a topic
name or a topic regex.
Sounds good. We could file a KIP to address it, following this plan:
*4.x*
1. add a new option specifically for accepting regex
2. warn the user if a regex is detected from the `topic` config
*5.x*
mark the topic config strictly non-regex
@DL1231 @AndrewJSchofield WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
