squah-confluent commented on code in PR #20780:
URL: https://github.com/apache/kafka/pull/20780#discussion_r2528265383
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -300,7 +302,7 @@ public class GroupCoordinatorConfig {
.define(GROUP_COORDINATOR_REBALANCE_PROTOCOLS_CONFIG, LIST,
GROUP_COORDINATOR_REBALANCE_PROTOCOLS_DEFAULT,
ConfigDef.ValidList.in(false,
Group.GroupType.documentValidValues()), MEDIUM,
GROUP_COORDINATOR_REBALANCE_PROTOCOLS_DOC)
.define(GROUP_COORDINATOR_NUM_THREADS_CONFIG, INT,
GROUP_COORDINATOR_NUM_THREADS_DEFAULT, atLeast(1), HIGH,
GROUP_COORDINATOR_NUM_THREADS_DOC)
- .define(GROUP_COORDINATOR_APPEND_LINGER_MS_CONFIG, INT,
GROUP_COORDINATOR_APPEND_LINGER_MS_DEFAULT, atLeast(0), MEDIUM,
GROUP_COORDINATOR_APPEND_LINGER_MS_DOC)
+ .define(GROUP_COORDINATOR_APPEND_LINGER_MS_CONFIG, INT,
GROUP_COORDINATOR_APPEND_LINGER_MS_DEFAULT, atLeast(-1), MEDIUM,
GROUP_COORDINATOR_APPEND_LINGER_MS_DOC)
Review Comment:
Thanks for the review. I tested -0.5 and it's already disallowed
```
org.apache.kafka.common.config.ConfigException: Invalid value -0.5 for
configuration group.coordinator.append.linger.ms: Not a number of type INT
at
app//org.apache.kafka.common.config.ConfigDef.parseType(ConfigDef.java:776)
at
app//org.apache.kafka.common.config.ConfigDef.parseValue(ConfigDef.java:531)
at
app//org.apache.kafka.common.config.ConfigDef.parse(ConfigDef.java:524)
at
app//org.apache.kafka.common.config.AbstractConfig.<init>(AbstractConfig.java:118)
at
app//org.apache.kafka.server.config.AbstractKafkaConfig.<init>(AbstractKafkaConfig.java:78)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
