m1a2st commented on code in PR #20844:
URL: https://github.com/apache/kafka/pull/20844#discussion_r2529458391
##########
clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java:
##########
@@ -1070,8 +1081,10 @@ private void validateIndividualValues(String name,
List<Object> values) {
}
public String toString() {
- return validString + (isEmptyAllowed ? " (empty config allowed)" :
" (empty not allowed)") +
- (isNullAllowed ? " (null config allowed)" : " (null not
allowed)");
+ String base = validString.validStrings.isEmpty() ? "any
non-duplicate values" : validString.toString();
Review Comment:
I have updated these config for following validator, and also updated the KIP
| config
| validator |
|--------------------------------------------------------------------------------|---------------------------------------------------------|
| BrokerSecurityConfigs ssl.cipher.suites
| ConfigDef.ValidList.anyNonDuplicateValues(true, false) |
| BrokerSecurityConfigs ssl.cipher.suites sasl.enabled.mechanisms
| ConfigDef.ValidList.anyNonDuplicateValues(false, false) |
| BrokerSecurityConfigs ssl.cipher.suites
sasl.kerberos.principal.to.local.rules |
ConfigDef.ValidList.anyNonDuplicateValues(false, false) |
| BrokerSecurityConfigs ssl.cipher.suites sasl.oauthbearer.expected.audience
| ConfigDef.ValidList.anyNonDuplicateValues(true, false) |
| DefaultConfigPropertyFilter config.properties.exclude
| ConfigDef.ValidList.anyNonDuplicateValues(true, false) |
| DefaultTopicFilter topics
| ConfigDef.ValidList.anyNonDuplicateValues(true, false) |
| DefaultTopicFilter topics.exclude
| ConfigDef.ValidList.anyNonDuplicateValues(true, false) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
