majialoong commented on code in PR #20891:
URL: https://github.com/apache/kafka/pull/20891#discussion_r2529816374
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/PluginUtils.java:
##########
@@ -209,6 +209,9 @@ public static Set<Path> pluginLocations(String pluginPath,
boolean failFast) {
for (String path : pluginPathElements) {
try {
Path pluginPathElement = Paths.get(path).toAbsolutePath();
+ if (pluginPath.isEmpty()) {
+ log.warn("Plugin path element is empty, evaluating to
{}.", pluginPathElement);
Review Comment:
This part of the code is also related to recovery, because empty states can
still occur here.
I have a question about this part: why does it only check whether
`plugin.path` is empty, instead of checking the elements within `plugin.path`?
The logs mention "plugin path element", which is what I originally wanted to
address. Would it make sense to check whether each path element is empty
instead?
@gharris1727 If you have time, could you please help me understand the
reasoning behind this behavior? Thank you very much for your help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
