lightzhao commented on PR #20849: URL: https://github.com/apache/kafka/pull/20849#issuecomment-3539524105
> This PR is unnecessary, unless I am misunderstanding the code. Any exception thrown by the `producerManager` or `consumerManager` will set the flag `initializationFailed = true` which is used in a [finally clause](https://github.com/apache/kafka/blob/5730f3130ddcabcba51e07fed3dd02787dc6b102/storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java#L378) that will then shut down the server. > > No need to guard against a resource leak if the process will terminate. > > Can you explain why you think this isn't sufficient? You are right, there's no need to prevent resource leaks when the process terminates, I will close this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
