AndrewJSchofield commented on code in PR #20895:
URL: https://github.com/apache/kafka/pull/20895#discussion_r2533670026
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareFetch.java:
##########
@@ -67,6 +70,9 @@ public void add(TopicIdPartition partition,
ShareInFlightBatch<K, V> batch) {
// but it might conceivably happen in some rare cases (such as
partition leader changes).
currentBatch.merge(batch);
}
+ if (batch.getAcquisitionLockTimeoutMs().isPresent()) {
Review Comment:
It's just making sure that we take the latest value, rather than overwriting
an existing value with no value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
