mjsax commented on code in PR #20910:
URL: https://github.com/apache/kafka/pull/20910#discussion_r2536895959
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableProcessValues.java:
##########
@@ -192,8 +181,13 @@ private ValueAndTimestamp<VOut> transformValue(final K
key, final ValueAndTimest
new RecordHeaders()
));
+ captureContext.forward = false;
Review Comment:
We need two modes for the `ForwardCaptureProcessorContext` -- one mode
(defaults), which forward directly, ie, executes the direct depth-first
"forward" processor chaining execution path. However here, for the "value
getter" we only want to do a lookup into the parent processor, process the
value, and capture it w/o forwarding is, because the result is the "oldValue"
of what we want to forward.... (Also a little bit hacky... suggestions how to
do this better are welcome).
Similar to above: we would only capture the last call to `forward()`...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
