ekuvardin commented on PR #20911: URL: https://github.com/apache/kafka/pull/20911#issuecomment-3552045164
@lucasbru Hi Lucas, could you help us out? We accidentally created two PRs for the same task, and we’ll actually be working together on it going forward. Right now we have a question about which approach is better. Could you coordinate us a bit and take a look at both PRs? One PR introduces a PatriciaTrie-based Set on top of PatriciaTrie, - https://github.com/apache/kafka/pull/20911 (this pr) and the other one uses a PatriciaTrie Map. - https://github.com/apache/kafka/pull/20912 In your opinion, which option is better to use? Both approaches work. By the way, I’ve already written to a colleague from the library Apache common collections and suggested adding a PatriciaTrie Set, but he’s very busy and hasn’t responded yet - https://github.com/apache/commons-collections/pull/589 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
