Copilot commented on code in PR #20946:
URL: https://github.com/apache/kafka/pull/20946#discussion_r2556752036
##########
docs/streams/developer-guide/app-reset-tool.html:
##########
@@ -65,6 +65,10 @@
</dl>
<div class="section" id="step-1-run-the-application-reset-tool">
<h2>Step 1: Run the application reset tool<a class="headerlink"
href="#step-1-run-the-application-reset-tool" title="Permalink to this
headline"></a></h2>
+ <p>If you are using <strong>AK 4.1 or earlier</strong>, run the
classic application reset tool as follows,
+ but if you are on <strong>AK 4.2+ (Streams Rebalance Protocol
enabled)</strong>, use the <a href = "">Streams groups CLI</a> instead.</p>
Review Comment:
There's a broken/empty link in the first reference to the Streams groups
CLI. The `href` attribute is empty: `<a href = "">`. This should point to
`kafka-streams-group-sh.html` like the second reference below does.
```suggestion
but if you are on <strong>AK 4.2+ (Streams Rebalance
Protocol enabled)</strong>, use the <a
href="kafka-streams-group-sh.html#delete-offsets">Streams groups CLI</a>
instead.</p>
```
##########
docs/streams/developer-guide/app-reset-tool.html:
##########
@@ -65,6 +65,10 @@
</dl>
<div class="section" id="step-1-run-the-application-reset-tool">
<h2>Step 1: Run the application reset tool<a class="headerlink"
href="#step-1-run-the-application-reset-tool" title="Permalink to this
headline"></a></h2>
+ <p>If you are using <strong>AK 4.1 or earlier</strong>, run the
classic application reset tool as follows,
+ but if you are on <strong>AK 4.2+ (Streams Rebalance Protocol
enabled)</strong>, use the <a href = "">Streams groups CLI</a> instead.</p>
+ <p>If you are using <strong>AK 4.1 or earlier</strong>, run the
classic application reset tool. If you are on <strong>AK 4.2+ with Streams
Rebalance Protocol enabled</strong>, use the <a
href="kafka-streams-group-sh.html#delete-offsets">Streams groups CLI</a>
instead to delete the offsets.</p>
+ <p>Run the application reset tool from the command line.</p>
<p>Invoke the application reset tool from the command line</p>
Review Comment:
This line duplicates the content of line 72 below. Both say nearly the same
thing about running/invoking the application reset tool from the command line.
One of these should be removed.
```suggestion
```
##########
docs/streams/developer-guide/app-reset-tool.html:
##########
@@ -65,6 +65,10 @@
</dl>
<div class="section" id="step-1-run-the-application-reset-tool">
<h2>Step 1: Run the application reset tool<a class="headerlink"
href="#step-1-run-the-application-reset-tool" title="Permalink to this
headline"></a></h2>
+ <p>If you are using <strong>AK 4.1 or earlier</strong>, run the
classic application reset tool as follows,
+ but if you are on <strong>AK 4.2+ (Streams Rebalance Protocol
enabled)</strong>, use the <a href = "">Streams groups CLI</a> instead.</p>
+ <p>If you are using <strong>AK 4.1 or earlier</strong>, run the
classic application reset tool. If you are on <strong>AK 4.2+ with Streams
Rebalance Protocol enabled</strong>, use the <a
href="kafka-streams-group-sh.html#delete-offsets">Streams groups CLI</a>
instead to delete the offsets.</p>
Review Comment:
Lines 68-70 contain duplicate/redundant content. Line 68-69 provides one
version of the guidance, then lines 70 repeats essentially the same message
with slightly different wording. Consider consolidating these into a single,
clear paragraph to avoid confusion.
```suggestion
<p>If you are using <strong>AK 4.1 or earlier</strong>, run the
classic application reset tool. If you are on <strong>AK 4.2+ (with Streams
Rebalance Protocol enabled)</strong>, use the <a
href="kafka-streams-group-sh.html#delete-offsets">Streams groups CLI</a>
instead to delete the offsets.</p>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
