DL1231 commented on code in PR #20847:
URL: https://github.com/apache/kafka/pull/20847#discussion_r2558452156
##########
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorConfig.java:
##########
@@ -82,6 +83,10 @@ public class ShareCoordinatorConfig {
public static final int COLD_PARTITION_SNAPSHOT_INTERVAL_MS_DEFAULT = 5 *
60 * 1000; // 5 minutes
public static final String COLD_PARTITION_SNAPSHOT_INTERVAL_MS_DOC = "The
duration in milliseconds that the share coordinator will wait between force
snapshotting share partitions which are not being updated.";
+ public static final String APPEND_MAX_BUFFER_SIZE_CONFIG =
"share.coordinator.append.max.buffer.size";
+ public static final int APPEND_MAX_BUFFER_SIZE_DEFAULT = 1024 * 1024 +
Records.LOG_OVERHEAD;
+ public static final String APPEND_MAX_BUFFER_SIZE_DOC = "The largest
buffer size allowed by ShareCoordinator (It is recommended not to exceed the
maximum allowed message size).";
Review Comment:
Actually, the `share.coordinator.append.max.buffer.size` can be larger than
the message size.
The max buffer size only determines whether the buffer can be recycled for
reuse. The actual upper limit of the buffer and the maximum message write size
are still controlled by the log message size.
This note is just a reminder that it’s not recommended to set the max buffer
size larger than the message size, as doing so serves no practical purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
