shashankhs11 commented on code in PR #20944:
URL: https://github.com/apache/kafka/pull/20944#discussion_r2560186948
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##########
@@ -3374,33 +3352,41 @@ public void
shouldCloseActiveTasksAndPropagateStreamsProducerExceptionsOnCleanSh
@Test
public void
shouldOnlyCommitRevokedStandbyTaskAndPropagatePrepareCommitException() {
Review Comment:
Yes, this is intentional. The stateupdater path does not call
`prepareCommit` when closing revoked standby tasks. Instead, it directly calls
`suspend()` and then `closeClean()`.
We would also need to rename the test in that case -
`shouldPropagateSuspendExceptionWhenRevokingStandbyTask`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
