lianetm commented on code in PR #20982:
URL: https://github.com/apache/kafka/pull/20982#discussion_r2561319145
##########
core/src/test/scala/integration/kafka/server/FetchFromFollowerIntegrationTest.scala:
##########
@@ -235,6 +234,7 @@ class FetchFromFollowerIntegrationTest extends
BaseFetchRequestTest {
val records = future.get(30, TimeUnit.SECONDS)
assertEquals(assignments(i), records.map(r => new
TopicPartition(r.topic, r.partition)).toSet)
}
+ consumers.foreach{ _.commitSync() }
Review Comment:
nit: should we disable auto-commits now that we're using manual?
##########
core/src/test/scala/integration/kafka/server/FetchFromFollowerIntegrationTest.scala:
##########
@@ -181,9 +181,8 @@ class FetchFromFollowerIntegrationTest extends
BaseFetchRequestTest {
}
}
- @Disabled
@ParameterizedTest(name =
TestInfoUtils.TestWithParameterizedGroupProtocolNames)
- @MethodSource(Array("getTestGroupProtocolParametersAll"))
+ @ValueSource(strings = Array("classic"))
Review Comment:
makes sense to me, this test is for the client-side `RangeAssignor` so it
does not apply to the consumer protocol
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
