apoorvmittal10 commented on code in PR #21001:
URL: https://github.com/apache/kafka/pull/21001#discussion_r2568047752
##########
core/src/main/scala/kafka/server/BrokerServer.scala:
##########
@@ -635,7 +635,8 @@ class BrokerServer(
new LogContext(s"[NetworkPartitionMetadataClient
broker=${config.brokerId}]")
),
Time.SYSTEM,
- config.interBrokerListenerName()
+ config.interBrokerListenerName(),
+ new SystemTimerReaper("network-partition-metadata-client-reaper", new
SystemTimer("network-partition-metadata-client"))
Review Comment:
> So, timer task was a good option here.
I could be wrong, but seems like we are complicating stuff without adding
much value. Isn't the reaper thread triggers busy polling?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
