showuon commented on PR #20859: URL: https://github.com/apache/kafka/pull/20859#issuecomment-3587821188
Thanks for the comment @kevin-wu24 ! > My opinion is we should go with the KIP-design of server-side idempotency for auto-join additions if we are going to implement this semantic change at all. We should not try to hastily implement this change just to land it in 4.2, especially if we intend to just revert this change and do the server-side idempotency in 4.3. Remember that bugs with this implementation will also lead to confusing/bad UX. If we want to change the semantic, we should do it just once, with what we believe to be the best design + implementation. What I'm afraid is that we shipped in v4.2 with "the aggressive auto-join semantic even if one node is just removed from the voters set". Then in v4.3, the semantic suddenly changes to "auto-join only when startup". It will confuse users and even surprise users. I think we should decide which semantic we want to deliver first, instead of deliver it then change it. > I believe we have gotten in KIPs after KIP-freeze before right? This KIP would be self-contained within KRaft module and only affect the auto-join feature, so maybe we can make this an exception and get this in for 4.2. I'm not sure if it will be accepted or not. Need the release manager's decision. > I don't see the harm in this waiting until 4.3, so we can give this change in semantic the proper time for review. Let's also wait and see what @jsancio thinks about all this too. I'd also like to hear @jsancio 's thought on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
