AntonVasant commented on code in PR #21013:
URL: https://github.com/apache/kafka/pull/21013#discussion_r2570542179


##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -3307,6 +3307,10 @@ private UpdateRegularExpressionsResult 
maybeUpdateRegularExpressions(
                     // We also trigger a refresh of the regexes in order to 
resolve it.
                     
throwIfRegularExpressionIsInvalid(updatedMember.subscribedTopicRegex());
                     requireRefresh = true;
+
+                    if (isNotEmpty(oldSubscribedTopicRegex) && 
group.numSubscribedMembers(oldSubscribedTopicRegex) != 0) {
+                        updateRegularExpressionsResult = 
UpdateRegularExpressionsResult.REGEX_UPDATED_AND_RESOLVED;
+                    }

Review Comment:
   and not the subscribers counts is empty for the new regex?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to