dajac commented on code in PR #21008:
URL: https://github.com/apache/kafka/pull/21008#discussion_r2571879735
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##########
@@ -2354,16 +2357,18 @@ public void onResignation(
}
/**
- * See {@link
GroupCoordinator#onNewMetadataImage(CoordinatorMetadataImage,
CoordinatorMetadataDelta)}.
+ * See {@link GroupCoordinator#onMetadataUpdate(MetadataDelta,
MetadataImage)}.
*/
@Override
- public void onNewMetadataImage(
- CoordinatorMetadataImage newImage,
- CoordinatorMetadataDelta delta
+ public void onMetadataUpdate(
+ MetadataDelta delta,
+ MetadataImage newImage
) {
throwIfNotActive();
- metadataImage = newImage;
- runtime.onNewMetadataImage(newImage, delta);
+ var wrappedImage = newImage == null ? null : new
KRaftCoordinatorMetadataImage(newImage);
+ var wrappedDelta = delta == null ? null : new
KRaftCoordinatorMetadataDelta(delta);
+ metadataImage = wrappedImage;
+ runtime.onNewMetadataImage(wrappedImage, wrappedDelta);
Review Comment:
addressed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
