Nikita-Shupletsov commented on code in PR #21111:
URL: https://github.com/apache/kafka/pull/21111#discussion_r2600541768
##########
streams/src/test/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionSendProcessorSupplierTest.java:
##########
@@ -295,6 +295,10 @@ public void
innerJoinShouldPropagateNothingWhenOldAndNewFKIsNull() {
innerJoinProcessor.process(new Record<>(pk, new
Change<>(leftRecordValue, leftRecordValue), 0));
assertThat(context.forwarded(), empty());
+
+ // test dropped-records sensors
+ assertEquals(1.0, getDroppedRecordsTotalMetric(context));
Review Comment:
according to the comment:
https://github.com/mjsax/kafka/blob/trunk/streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionSendProcessorSupplier.java#L177
it's an invalid situation, so we report it as a dropped record.
Please correct me if I am wrong with my conclusion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
