kamalcph commented on code in PR #21090:
URL: https://github.com/apache/kafka/pull/21090#discussion_r2622045350
##########
storage/src/main/java/org/apache/kafka/server/log/remote/quota/RLMQuotaManager.java:
##########
@@ -93,6 +123,22 @@ public void record(double value) {
sensor().record(value, time.milliseconds(), false);
}
+ /**
+ * Record quota usage with topic context for observability
+ */
+ public void recordWithTopic(String topic, double value) {
+ // Record global quota
+ sensor().record(value, time.milliseconds(), false);
+
+ // Record per-topic quota usage if brokerTopicStats available
+ if (brokerTopicStats != null && value > 0) {
+ var meter =
brokerTopicStats.topicStats(topic).remoteFetchQuotaBytesRate();
Review Comment:
Why do we want `remoteFetchQuotaBytesRate` when `remoteFetchBytesRate` is
available per topic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
