DL1231 commented on code in PR #21150:
URL: https://github.com/apache/kafka/pull/21150#discussion_r2626393191
##########
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManager.java:
##########
@@ -1044,6 +1049,9 @@ private void copyLogSegment(UnifiedLog log, LogSegment
segment, RemoteLogSegment
try {
customMetadata =
remoteStorageManagerPlugin.get().copyLogSegmentData(copySegmentStartedRlsm,
segmentData);
+ } catch (RetriableRemoteStorageException e) {
+ logger.info("Copy failed with retriable error for segment {}",
copySegmentStartedRlsm.remoteLogSegmentId());
+ throw e;
} catch (RemoteStorageException e) {
logger.info("Copy failed, cleaning segment {}",
copySegmentStartedRlsm.remoteLogSegmentId());
try {
Review Comment:
> when deleteRemoteLogSegment throws RetriableRemoteStorageException, we
don't catch it.
as @kamalcph pointed out, RRSE extends RSE, so when `deleteRemoteLogSegment`
throws RRSE, it will be caught.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
