shashankhs11 commented on code in PR #20292:
URL: https://github.com/apache/kafka/pull/20292#discussion_r2629452415
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/PartitionGroupTest.java:
##########
@@ -912,6 +925,81 @@ public void shouldIdleAsSpecifiedWhenLagIsZero() {
}
}
+ @Test
+ public void
shouldUpdateTotalBytesBufferedOnRecordsAdditionAndConsumption() {
+ final PartitionGroup group = getBasicGroup();
+
+ assertEquals(0, group.numBuffered());
+ assertEquals(0L, group.totalBytesBuffered());
+
+ // add three 3 records with timestamp 1, 5, 3 to partition-1
+ final List<ConsumerRecord<byte[], byte[]>> list1 = Arrays.asList(
+ new ConsumerRecord<>("topic", 1, 1L, new
MockTime().milliseconds(), TimestampType.CREATE_TIME, recordKey.length,
recordValue.length, recordKey, recordValue, new RecordHeaders(),
Optional.empty()),
+ new ConsumerRecord<>("topic", 1, 5L, new
MockTime().milliseconds(), TimestampType.CREATE_TIME, recordKey.length,
recordValue.length, recordKey, recordValue, new RecordHeaders(),
Optional.empty()),
+ new ConsumerRecord<>("topic", 1, 3L, new
MockTime().milliseconds(), TimestampType.CREATE_TIME, recordKey.length,
recordValue.length, recordKey, recordValue, new RecordHeaders(),
Optional.empty()));
+
+ long partition1TotalBytes = getBytesBufferedForRawRecords(list1);
+ group.addRawRecords(partition1, list1);
+
+ verifyBuffered(3, 3, 0, group);
+ assertEquals(group.totalBytesBuffered(), partition1TotalBytes);
+ assertEquals(-1L, group.streamTime());
+ assertEquals(0.0, metrics.metric(lastLatenessValue).metricValue());
+ assertThat(metrics.metric(totalBytesValue).metricValue(), is((double)
partition1TotalBytes));
+
+ StampedRecord record;
+ final PartitionGroup.RecordInfo info = new PartitionGroup.RecordInfo();
+
+ // get first two records from partition 1
+ record = group.nextRecord(info, time.milliseconds());
+ assertEquals(record.timestamp, 1L);
Review Comment:
addressed in 52ad5fc
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/PartitionGroupTest.java:
##########
@@ -912,6 +925,81 @@ public void shouldIdleAsSpecifiedWhenLagIsZero() {
}
}
+ @Test
+ public void
shouldUpdateTotalBytesBufferedOnRecordsAdditionAndConsumption() {
+ final PartitionGroup group = getBasicGroup();
+
+ assertEquals(0, group.numBuffered());
+ assertEquals(0L, group.totalBytesBuffered());
+
+ // add three 3 records with timestamp 1, 5, 3 to partition-1
+ final List<ConsumerRecord<byte[], byte[]>> list1 = Arrays.asList(
+ new ConsumerRecord<>("topic", 1, 1L, new
MockTime().milliseconds(), TimestampType.CREATE_TIME, recordKey.length,
recordValue.length, recordKey, recordValue, new RecordHeaders(),
Optional.empty()),
+ new ConsumerRecord<>("topic", 1, 5L, new
MockTime().milliseconds(), TimestampType.CREATE_TIME, recordKey.length,
recordValue.length, recordKey, recordValue, new RecordHeaders(),
Optional.empty()),
+ new ConsumerRecord<>("topic", 1, 3L, new
MockTime().milliseconds(), TimestampType.CREATE_TIME, recordKey.length,
recordValue.length, recordKey, recordValue, new RecordHeaders(),
Optional.empty()));
+
+ long partition1TotalBytes = getBytesBufferedForRawRecords(list1);
+ group.addRawRecords(partition1, list1);
+
+ verifyBuffered(3, 3, 0, group);
+ assertEquals(group.totalBytesBuffered(), partition1TotalBytes);
+ assertEquals(-1L, group.streamTime());
+ assertEquals(0.0, metrics.metric(lastLatenessValue).metricValue());
+ assertThat(metrics.metric(totalBytesValue).metricValue(), is((double)
partition1TotalBytes));
+
+ StampedRecord record;
+ final PartitionGroup.RecordInfo info = new PartitionGroup.RecordInfo();
+
+ // get first two records from partition 1
+ record = group.nextRecord(info, time.milliseconds());
+ assertEquals(record.timestamp, 1L);
+ record = group.nextRecord(info, time.milliseconds());
+ assertEquals(record.timestamp, 5L);
Review Comment:
addressed in 52ad5fc
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/PartitionGroupTest.java:
##########
@@ -912,6 +925,81 @@ public void shouldIdleAsSpecifiedWhenLagIsZero() {
}
}
+ @Test
+ public void
shouldUpdateTotalBytesBufferedOnRecordsAdditionAndConsumption() {
+ final PartitionGroup group = getBasicGroup();
+
+ assertEquals(0, group.numBuffered());
+ assertEquals(0L, group.totalBytesBuffered());
+
+ // add three 3 records with timestamp 1, 5, 3 to partition-1
+ final List<ConsumerRecord<byte[], byte[]>> list1 = Arrays.asList(
+ new ConsumerRecord<>("topic", 1, 1L, new
MockTime().milliseconds(), TimestampType.CREATE_TIME, recordKey.length,
recordValue.length, recordKey, recordValue, new RecordHeaders(),
Optional.empty()),
+ new ConsumerRecord<>("topic", 1, 5L, new
MockTime().milliseconds(), TimestampType.CREATE_TIME, recordKey.length,
recordValue.length, recordKey, recordValue, new RecordHeaders(),
Optional.empty()),
+ new ConsumerRecord<>("topic", 1, 3L, new
MockTime().milliseconds(), TimestampType.CREATE_TIME, recordKey.length,
recordValue.length, recordKey, recordValue, new RecordHeaders(),
Optional.empty()));
+
+ long partition1TotalBytes = getBytesBufferedForRawRecords(list1);
+ group.addRawRecords(partition1, list1);
+
+ verifyBuffered(3, 3, 0, group);
+ assertEquals(group.totalBytesBuffered(), partition1TotalBytes);
+ assertEquals(-1L, group.streamTime());
+ assertEquals(0.0, metrics.metric(lastLatenessValue).metricValue());
+ assertThat(metrics.metric(totalBytesValue).metricValue(), is((double)
partition1TotalBytes));
+
+ StampedRecord record;
+ final PartitionGroup.RecordInfo info = new PartitionGroup.RecordInfo();
+
+ // get first two records from partition 1
+ record = group.nextRecord(info, time.milliseconds());
+ assertEquals(record.timestamp, 1L);
+ record = group.nextRecord(info, time.milliseconds());
+ assertEquals(record.timestamp, 5L);
+
+ partition1TotalBytes -=
getBytesBufferedForRawRecords(Arrays.asList(list1.get(0), list1.get(1)));
Review Comment:
addressed in 52ad5fc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
