Pankraz76 commented on code in PR #21171:
URL: https://github.com/apache/kafka/pull/21171#discussion_r2630538644
##########
build.gradle:
##########
@@ -2882,15 +2876,6 @@ project(':streams:streams-scala') {
jar {
dependsOn 'copyDependantLibs'
}
-
- apply plugin: 'com.diffplug.spotless'
- spotless {
- scala {
- target '**/*.scala'
Review Comment:
yes kind of, but not really.
##########
build.gradle:
##########
@@ -2882,15 +2876,6 @@ project(':streams:streams-scala') {
jar {
dependsOn 'copyDependantLibs'
}
-
- apply plugin: 'com.diffplug.spotless'
- spotless {
- scala {
- target '**/*.scala'
-
scalafmt("$versions.scalafmt").configFile('../../checkstyle/.scalafmt.conf').scalaMajorVersion(versions.baseScala)
- licenseHeaderFile '../../checkstyle/java.header', 'package'
Review Comment:
relative kind of fragile (error prone).
##########
build.gradle:
##########
@@ -184,6 +184,8 @@ allprojects {
}
}
}
+
+ apply from: "$rootDir/gradle/spotless.gradle"
Review Comment:
SSOT / SPOT
Single source / single point
##########
build.gradle:
##########
@@ -866,14 +868,6 @@ subprojects {
skipProjects = [ ":jmh-benchmarks", ":trogdor" ]
skipConfigurations = [ "zinc" ]
}
- apply plugin: 'com.diffplug.spotless'
Review Comment:
dry
##########
build.gradle:
##########
@@ -2882,15 +2876,6 @@ project(':streams:streams-scala') {
jar {
dependsOn 'copyDependantLibs'
}
-
- apply plugin: 'com.diffplug.spotless'
Review Comment:
dry
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
