chia7712 commented on code in PR #21164:
URL: https://github.com/apache/kafka/pull/21164#discussion_r2637815628
##########
tests/kafkatest/services/kafka/kafka.py:
##########
@@ -358,7 +358,7 @@ def __init__(self, context, num_nodes, zk,
security_protocol=SecurityConfig.PLAI
extra_kafka_opts=extra_kafka_opts, tls_version=tls_version,
isolated_kafka=self,
allow_zk_with_kraft=self.allow_zk_with_kraft,
server_prop_overrides=server_prop_overrides,
dynamicRaftQuorum=self.dynamicRaftQuorum,
- use_streams_groups=self.use_streams_groups
+ use_transactions_v2=self.use_transactions_v2,
use_streams_groups=self.use_streams_groups
Review Comment:
The E2E tests are still using the internal config `group.share.enable`. We
should probably replace it with the public configuration `--feature
share.version=1`. Using the internal config seems redundant now, given that the
share consumer is production-ready starting from version 4.2.0. Therefore, we
should remove `group.share.enable`
@AndrewJSchofield @apoorvmittal10 WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
