chia7712 commented on code in PR #20938:
URL: https://github.com/apache/kafka/pull/20938#discussion_r2638800463


##########
server/src/test/java/org/apache/kafka/server/BootstrapControllersIntegrationTest.java:
##########
@@ -357,4 +357,9 @@ public void testDescribeConfigs(ClusterInstance 
clusterInstance) throws Exceptio
             assertEquals("2", configEntry.value());
         }
     }
+
+    @ClusterTest(controllers = 1, standalone = true)
+    public void 
testIncrementalAlterConfigsByControllersWithDynamicQuorum(ClusterInstance 
clusterInstance) throws Exception {
+        testIncrementalAlterConfigs(clusterInstance, true);

Review Comment:
   Could you add a test to ensure all controllers can accept dynamic 
configurations? The current logic only verifies the single initial controller



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to