jiafu1115 commented on PR #21199: URL: https://github.com/apache/kafka/pull/21199#issuecomment-3684808292
@mumrah @chia7712 @Pankraz76 Done for the code refactor and tests. I also add more file type which need to be exclude from tests. It is the final status for me now. If you think it is worthy for this PR. you can help to review. Thanks. ### Test 1: Only doc change <img width="658" height="562" alt="image" src="https://github.com/user-attachments/assets/0322ebc8-b387-4ff9-8ddd-2b959569ee3c"; /> ### Test 2: Only code change <img width="571" height="425" alt="image" src="https://github.com/user-attachments/assets/2b87e9e6-0368-4a0c-b143-e827f4a47656"; /> ### Test 3: Code and Doc changed <img width="787" height="527" alt="image" src="https://github.com/user-attachments/assets/f6c84fae-b2b8-475d-8d01-bf1d9dda6e98"; /> BTW. I record some information found in tests here for your reference: 1 "predicate-quantifier: 'every'" will got one warn log but it shouldn't be deleted due to the behavior will be changed accroding to the test result. `_Warning: Unexpected input(s) 'predicate-quantifier', valid inputs are ['token', 'working-directory', 'ref', 'base', 'filters', 'list-files', 'initial-fetch-depth']_` 2 ${{ steps.filter.outputs.docs && !steps.filter.outputs.codes }}" **is not equal with** ${{ steps.filter.outputs.docs == 'true' && steps.filter.outputs.codes == 'false' }}". @Pankraz76 so I rollback part of the code. I also check the plugin example. you can check my test result here directly. ``` echo "steps.filter.outputs.docs: ${{ steps.filter.outputs.docs }}" echo "steps.filter.outputs.codes: ${{ steps.filter.outputs.codes }}" echo "doc-change-only: ${{ steps.filter.outputs.docs && !steps.filter.outputs.codes }}" echo "doc-change-only: ${{ steps.filter.outputs.docs == 'true' && steps.filter.outputs.codes == 'false' }}" the result: true. false. false, true ``` Thanks ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
