[
https://issues.apache.org/jira/browse/KAFKA-3881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16789076#comment-16789076
]
ASF GitHub Bot commented on KAFKA-3881:
---------------------------------------
dbrinegar commented on pull request #6420: KAFKA-3881: use plain topic tag in
Fetcher metrics
URL: https://github.com/apache/kafka/pull/6420
Reverts topic.replace conversion of dots to underbars in topic values for
Fetcher metrics, so topic values are consistent across metrics.
The original `topic.replace` code was introduced in
https://github.com/apache/kafka/pull/939 following a pattern where the topic
value would be prefixed with "topic-" and dots would be converted to underbars.
This pattern was then partially backed out, leaving the dots conversion by
mistake.
Note that all other metric collections use the topic value as-is without
conversion, so this change should align topic values from Fetcher with other
metric topic values. The failure to align only happens when the topic value has
a dot, so is understandably hard to find otherwise.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove the replacing logic from "." to "_" in Fetcher
> -----------------------------------------------------
>
> Key: KAFKA-3881
> URL: https://issues.apache.org/jira/browse/KAFKA-3881
> Project: Kafka
> Issue Type: Bug
> Components: consumer, metrics
> Reporter: Guozhang Wang
> Assignee: Tom Bentley
> Priority: Major
> Labels: newbie, patch-available
>
> The logic of replacing "." to "_" in metrics names / tags was originally
> introduced in the core package's metrics since Graphite treats "." as
> hierarchy separators (see KAFKA-1902); for the client metrics, it is supposed
> that the GraphiteReported should take care of this itself rather than letting
> Kafka metrics to special handle for it. In addition, right now only consumer
> Fetcher had replace, but producer Sender does not have it actually.
> So we should consider removing this logic in the consumer Fetcher's metrics
> package. NOTE that this is a public API backward incompatible change.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
