AndrewJSchofield commented on code in PR #21217:
URL: https://github.com/apache/kafka/pull/21217#discussion_r2650852584
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -1952,6 +1952,8 @@ private int acquireSubsetBatchRecords(
// the delivery limit and already have some records to return
in response then skip processing
// the current record, which shall be delivered alone in next
fetch.
if (maxDeliveryCount > 2 && recordDeliveryCount ==
maxDeliveryCount - 1 && acquiredCount > 0) {
+ log.info("The offset {} is on last delivery attempt in
share partition: {}-{}, should be delivered alone in next fetch",
Review Comment:
Agree, WARN is preferable.
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -1995,13 +1997,17 @@ private int acquireSubsetBatchRecords(
// Delivered alone.
if (offsetState.getValue().deliveryCount() == maxDeliveryCount
&& maxDeliveryCount > 2) {
+ log.info("The offset {} is on last delivery attempt in
share partition: {}-{}, should be delivered alone in this fetch",
Review Comment:
And here of course.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
