[
https://issues.apache.org/jira/browse/KAFKA-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16789559#comment-16789559
]
ASF GitHub Bot commented on KAFKA-7976:
---------------------------------------
rajinisivaram commented on pull request #6426: KAFKA-7976; Update config before
notifying controller of unclean leader update
URL: https://github.com/apache/kafka/pull/6426
When unclean leader election is enabled dynamically on brokers, we notify
controller of the update before updating KafkaConfig. When processing this
event, controller's decision to elect unclean leaders is based on the current
KafkaConfig, so there is a small timing window when the controller may not
elect unclean leader because `KafkaConfig` of the server was not yet updated.
The PR fixes this timing window by using the existing `BrokerReconfigurable`
interface used by other classes which rely on the current value of
`KafkaConfig`.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Flaky Test DynamicBrokerReconfigurationTest#testUncleanLeaderElectionEnable
> ---------------------------------------------------------------------------
>
> Key: KAFKA-7976
> URL: https://issues.apache.org/jira/browse/KAFKA-7976
> Project: Kafka
> Issue Type: Bug
> Components: core, unit tests
> Affects Versions: 2.2.0, 2.3.0
> Reporter: Matthias J. Sax
> Assignee: Rajini Sivaram
> Priority: Critical
> Labels: flaky-test
> Fix For: 2.3.0, 2.2.1
>
>
> To get stable nightly builds for `2.2` release, I create tickets for all
> observed test failures.
> [https://builds.apache.org/blue/organizations/jenkins/kafka-2.2-jdk8/detail/kafka-2.2-jdk8/28/]
> {quote}java.lang.AssertionError: Unclean leader not elected
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at
> kafka.server.DynamicBrokerReconfigurationTest.testUncleanLeaderElectionEnable(DynamicBrokerReconfigurationTest.scala:488){quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
