chia7712 commented on code in PR #20456:
URL: https://github.com/apache/kafka/pull/20456#discussion_r2657538559
##########
transaction-coordinator/src/test/java/org/apache/kafka/coordinator/transaction/TransactionLogTest.java:
##########
@@ -253,11 +248,9 @@ void testDeserializeFutureTransactionLogValue() {
// Read the buffer with readTxnRecordValue.
buffer.rewind();
- var txnMetadata = TransactionLog.readTxnRecordValue("transaction-id",
buffer);
-
- assertFalse(txnMetadata.isEmpty(), "Expected transaction metadata but
got none");
+ var metadata = TransactionLog.readTxnRecordValue("transaction-id",
buffer);
- var metadata = txnMetadata.get();
+ assertFalse(metadata == null, "Expected transaction metadata but got
none");
Review Comment:
```java
assertNotNull(metadata, "Expected transaction metadata but got none");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
