gaurav-narula commented on code in PR #21244:
URL: https://github.com/apache/kafka/pull/21244#discussion_r2661621304
##########
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##########
@@ -5514,6 +5514,16 @@ class ReplicaManagerTest {
try {
val spiedPartition = spy(Partition(tpId, time, replicaManager))
+
+ val blockPromotion = new AtomicBoolean(false)
Review Comment:
Thanks for the change @Parkerhiphop. You might want to initialise this as
`new AtomicBoolean(true)` and avoid invoking `blockPromotion.set(true)`
explicitly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
