lianetm commented on code in PR #21267:
URL: https://github.com/apache/kafka/pull/21267#discussion_r2669803363
##########
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##########
@@ -4476,7 +4476,7 @@ class PlaintextAdminIntegrationTest extends
BaseAdminIntegrationTest {
TestUtils.waitUntilTrue(() => {
val firstGroup = client.listGroups().all().get().stream()
.filter(g => g.groupId() == streamsGroupId).findFirst().orElse(null)
- firstGroup.groupState().orElse(null) == GroupState.NOT_READY &&
firstGroup.groupId() == streamsGroupId
+ firstGroup != null && firstGroup.groupState().orElse(null) ==
GroupState.NOT_READY && firstGroup.groupId() == streamsGroupId
Review Comment:
yeap, would it make sense to apply the fix consistently to the other tests
too? (`testDescribeStreamsGroups`,
`testDescribeStreamsGroupsForStatelessTopology` and
`testListStreamsGroupOffsets` it seems, even though they haven't been flaky so
far)
##########
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##########
@@ -4476,7 +4476,7 @@ class PlaintextAdminIntegrationTest extends
BaseAdminIntegrationTest {
TestUtils.waitUntilTrue(() => {
val firstGroup = client.listGroups().all().get().stream()
.filter(g => g.groupId() == streamsGroupId).findFirst().orElse(null)
- firstGroup.groupState().orElse(null) == GroupState.NOT_READY &&
firstGroup.groupId() == streamsGroupId
+ firstGroup != null && firstGroup.groupState().orElse(null) ==
GroupState.NOT_READY && firstGroup.groupId() == streamsGroupId
Review Comment:
also makes sense to me (only for the tests that filter the stream)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
