YutaLin commented on code in PR #21266:
URL: https://github.com/apache/kafka/pull/21266#discussion_r2674439202
##########
transaction-coordinator/src/main/java/org/apache/kafka/coordinator/transaction/RPCProducerIdManager.java:
##########
@@ -188,7 +188,7 @@ protected void
handleAllocateProducerIdsResponse(ClientResponse clientResponse)
}
private boolean sanityCheckResponse(AllocateProducerIdsResponseData data) {
- if (data.producerIdStart() <
currentProducerIdBlock.get().lastProducerId()) {
+ if (data.producerIdStart() <=
currentProducerIdBlock.get().lastProducerId()) {
Review Comment:
Hi @chia7712, that's a great suggestion! I've made the change, I hope ci god
is happy now.
##########
transaction-coordinator/src/main/java/org/apache/kafka/coordinator/transaction/RPCProducerIdManager.java:
##########
@@ -188,7 +188,7 @@ protected void
handleAllocateProducerIdsResponse(ClientResponse clientResponse)
}
private boolean sanityCheckResponse(AllocateProducerIdsResponseData data) {
- if (data.producerIdStart() <
currentProducerIdBlock.get().lastProducerId()) {
+ if (data.producerIdStart() <=
currentProducerIdBlock.get().lastProducerId()) {
Review Comment:
Hi @chia7712, that's a great suggestion! I've made the change, I hope CI god
is happy now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
