adixitconfluent commented on code in PR #21262: URL: https://github.com/apache/kafka/pull/21262#discussion_r2674883564
########## server/src/main/java/org/apache/kafka/server/share/fetch/acquire/AcquireStrategy.java: ########## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.server.share.fetch.acquire; + +import org.apache.kafka.common.message.ShareFetchResponseData.AcquiredRecords; +import org.apache.kafka.server.share.fetch.InFlightBatch; + +import java.util.List; + +/** + * Strategy interface for acquiring records in different modes. + * <p> + * Two modes are supported: + * <ul> + * <li>{@code BATCH_OPTIMIZED} - Acquires records in batches optimized for throughput, + * potentially splitting large fetches into multiple batches based on batch size.</li> + * <li>{@code RECORD_LIMIT} - Acquires up to the requested number of records, + * creating a single batch only.</li> + * </ul> + */ +public interface AcquireStrategy { Review Comment: The point of the refactor is to move the code only which is different for the strategies. If we move the entire acquire logic outside `SharePartition`, there will be a lot of duplicate code that we need to manage. Also, for adding new strategy, we will require more code to implement it along with possible duplication of some code. Hence, the best idea to me was to decide the places in acquire which are different and acordingly design the APIs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
