dejan2609 commented on PR #20866: URL: https://github.com/apache/kafka/pull/20866#issuecomment-3729570051
> _I am a bit on the fence for this change. On one hand, I don't like depending on .sourceSets.test.output in some places in the build.gradle file and on configurations/artifacts in others. On the other hand, I also don't like generating an empty folder (i.e. build/classes/java) just to satisfy a stricter expectation._ I can relate with all of this @clolov. Thing is that Kafka Gradle build is complicated due to a fact that people want Kafka to perform various complicated things. And on top of that: dependencies versions just have to move forward: sooner or later this Shadow gradle plugin version will have to be bumped, one way or another. All-in-all, we can either choose to: 1. put some duct tape and/or WD-40 and call it a day (like here, in this PR :slightly_smiling_face:) 2. re-factor Gradle build (and remove some technical debt all along) - :warning: pitfall - it can be tricky 3. something else :nerd_face: Open invitation to entire community: what is your take on this ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
