mimaison commented on code in PR #21273:
URL: https://github.com/apache/kafka/pull/21273#discussion_r2676965309
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -1158,6 +1158,8 @@ class ReplicaManager(val config: KafkaConfig,
throw new InvalidTopicException("The topic name is too long.")
if (!logManager.isLogDirOnline(destinationDir))
throw new KafkaStorageException(s"Log directory $destinationDir is
offline")
+ if (logManager.cordonedLogDirs().contains(destinationDir))
+ throw new InvalidReplicaAssignmentException(s"Log directory
$destinationDir is cordoned")
Review Comment:
The KIP mentioned returning `KAFKA_STORAGE_ERROR` but I think
`INVALID_REPLICA_ASSIGNMENT` is more appropriate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
