chia7712 commented on code in PR #21277:
URL: https://github.com/apache/kafka/pull/21277#discussion_r2679496870
##########
docs/configuration/tiered-storage-configs.md:
##########
@@ -43,6 +43,9 @@ Additional configurations can be provided for different types
of clients using t
# Configs for admin, producer, and consumer clients
<rlmm.prefix>.remote.log.metadata.common.client.<kafka.property> = <value>
+
+ # Configs only for admin client
+ <rlmm.prefix>.remote.log.metadata.admin.<kafka.property> = <value>
Review Comment:
Could you please document this fantastic feature in `upgrade.md`?
##########
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerConfig.java:
##########
@@ -246,6 +264,7 @@ public String toString() {
", commonProps=" + configMapToRedactedString(commonProps,
AdminClientConfig.configDef()) +
Review Comment:
Since `commonProps` has been replaced by `adminProps`, do we still need to
expose it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
