UladzislauBlok commented on code in PR #21289:
URL: https://github.com/apache/kafka/pull/21289#discussion_r2679758587
##########
core/src/main/scala/kafka/utils/CoreUtils.scala:
##########
@@ -108,6 +108,11 @@ object CoreUtils {
/**
* Execute the given function inside the lock
*/
+ // COMMENT FOR PR: We don't need to keep this function,
+ // because this functionality was already provided by LockUtils
+ // see server-common.server.util
+ // see LockUtils#inLock(Lock lock, ThrowingSupplier<T, E> supplier)
+ // see LockUtils#inLock(Lock lock, ThrowingRunnable<E> runnable)
def inLock[T](lock: Lock)(fun: => T): T = {
Review Comment:
This method was already moved to `LockUtils`
- see LockUtils#inLock(Lock lock, ThrowingSupplier<T, E> supplier)
- see LockUtils#inLock(Lock lock, ThrowingRunnable<E> runnable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
