gensericghiro commented on code in PR #18198:
URL: https://github.com/apache/kafka/pull/18198#discussion_r2684246938
##########
tools/src/test/java/org/apache/kafka/tools/consumer/ConsoleConsumerTest.java:
##########
@@ -370,8 +374,11 @@ public void testOffsetsMessageFormatter(ClusterInstance
cluster) throws Exceptio
}
}
- @ClusterTest(brokers = 3)
Review Comment:
Was this needed before?
##########
tools/src/test/java/org/apache/kafka/tools/consumer/ConsoleConsumerTest.java:
##########
@@ -458,9 +493,10 @@ private Consumer<byte[], byte[]>
createOffsetConsumer(ClusterInstance cluster) {
return new KafkaConsumer<>(props);
}
- private Consumer<byte[], byte[]>
createGroupMetaDataConsumer(ClusterInstance cluster) {
+ private Consumer<byte[], byte[]>
createGroupMetaDataConsumer(ClusterInstance cluster, GroupProtocol
groupProtocol) {
Properties props = consumerProps(cluster);
props.put(AUTO_OFFSET_RESET_CONFIG, "earliest");
+ props.put(GROUP_PROTOCOL_CONFIG, groupProtocol.name);
Review Comment:
nit: could be good to use the getter for name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
