UladzislauBlok commented on PR #21304: URL: https://github.com/apache/kafka/pull/21304#issuecomment-3750048950
@mjsax Hello, I found a leak of internal implementation details in the api module. We’re currently exposing InternalFixedKeyRecordFactory with a "do not use" doc warning, which isn't ideal. I propose exposing only the interface and moving the implementation/constructor to the internals module with package-private access. We can then remove the factory and refactor the record similarly, providing a public API to create it from scratch. This PR is currently just a POC to demonstrate the issue. If we agree on the fix, I will create a Jira ticket and a KIP -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
