ekuvardin commented on code in PR #20912: URL: https://github.com/apache/kafka/pull/20912#discussion_r2695210248
########## LICENSE-binary: ########## @@ -208,6 +208,7 @@ License Version 2.0: - caffeine-3.2.0 - commons-beanutils-1.11.0 - commons-collections-3.2.2 +- commons-collections4-4.5.0 Review Comment: I tried to find a PrefixTrie or PatriciaTrie in the libraries we already use, but without success. I don’t consider writing our own implementation to be a good idea. What makes the situation even worse is that we already have a version of commons-collections-3.2.2 used somewhere deep in the codebase, but it is not compatible with the newer commons-collections4-4.5.0 (they even split it into a separate “4” module specifically because of this). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
