AndrewJSchofield commented on PR #21292: URL: https://github.com/apache/kafka/pull/21292#issuecomment-3758999295
@seekskyworld Thanks for the PR, but I don't think it's necessary since #21239. If I look at develocity, I only see a failure on the 4.2 branch which does not have that PR. If I run locally, I can run 200 iterations with no failures. Looking at the existing test and the modified test in this PR, they aren't quite doing the same thing. The existing test waits in `poll(Duration)` until the exception is thrown, and I think we should retain a test for that logic. As a result, I think we should close this PR. Thanks for all the effort, but I feel this PR is no longer needed. `testPollThrowsInterruptExceptionIfInterrupted` does however fail. If you're interested in fixing that one, I'd be very grateful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
