Copilot commented on code in PR #21317:
URL: https://github.com/apache/kafka/pull/21317#discussion_r2698554121
##########
core/src/test/scala/integration/kafka/api/IntegrationTestHarness.scala:
##########
@@ -251,6 +252,9 @@ abstract class IntegrationTestHarness extends
KafkaServerTestHarness {
props ++= configOverrides
configsToRemove.foreach(props.remove(_))
+ val boxed: Optional[java.lang.Short] =
+ replicationFactor.map[java.lang.Short](s => java.lang.Short.valueOf(s))
+
Review Comment:
There is trailing whitespace on line 257 after the closing parenthesis. This
should be removed to maintain code cleanliness and adhere to standard
formatting practices.
```suggestion
```
##########
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##########
@@ -4465,10 +4465,12 @@ class PlaintextAdminIntegrationTest extends
BaseAdminIntegrationTest {
val config = createConfig
client = Admin.create(config)
+ val unavailableReplicationFactorInThisCluster = 9999.toShort
val streams = createStreamsGroup(
inputTopics = Set(testTopicName),
changelogTopics = Set(testTopicName + "-changelog"),
- streamsGroupId = streamsGroupId
+ streamsGroupId = streamsGroupId,
+ replicationFactor =
Optional.of(unavailableReplicationFactorInThisCluster),
Review Comment:
There is a trailing comma after the last parameter in the function call.
While this is syntactically valid in Scala, it's inconsistent with the other
usages of `createStreamsGroup` in the same file (e.g., lines 4421-4425,
4516-4519) where no trailing comma is used. Consider removing it for
consistency.
```suggestion
replicationFactor =
Optional.of(unavailableReplicationFactorInThisCluster)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
