unknowntpo opened a new pull request, #21378: URL: https://github.com/apache/kafka/pull/21378
This is a backport of PR #21370, with an additional checkstyle fix (adding a `final` keyword to make checkstyle works in 4.2 branch). --- This patch fixed two mismatch between [KIP-1034](https://cwiki.apache.org/confluence/display/KAFKA/KIP-1034%3A+Dead+letter+queue+in+Kafka+Streams#KIP1034:DeadletterqueueinKafkaStreams-ProposedChanges) and the actual implementation: - Incorrect value of `HEADER_ERRORS_EXCEPTION_NAME`, it should be the name of the thrown exception, not exception's String representation. - Original headers from record that causes exception should be added to dlq record headers. References: - https://github.com/apache/kafka/pull/17942#discussion_r2737868443 - https://github.com/apache/kafka/pull/17942#discussion_r2738033268 - [KIP-1034](https://cwiki.apache.org/confluence/display/KAFKA/KIP-1034%3A+Dead+letter+queue+in+Kafka+Streams#KIP1034:DeadletterqueueinKafkaStreams-ProposedChanges) Reviewers: Lucas Brutschy <[email protected]> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
