[
https://issues.apache.org/jira/browse/KAFKA-8119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16794539#comment-16794539
]
ASF GitHub Bot commented on KAFKA-8119:
---------------------------------------
rajinisivaram commented on pull request #6457: KAFKA-8119; Ensure KafkaConfig
listener accessors work during update
URL: https://github.com/apache/kafka/pull/6457
Use the same config to obtain all properties used in each KafkaConfig
accessor method to ensure that validation doesn't fail if config was updated
during the method.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> KafkaConfig listener accessors may fail during dynamic update
> -------------------------------------------------------------
>
> Key: KAFKA-8119
> URL: https://issues.apache.org/jira/browse/KAFKA-8119
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 2.2.0
> Reporter: Rajini Sivaram
> Assignee: Rajini Sivaram
> Priority: Major
> Fix For: 2.3.0, 2.2.1
>
>
> Noticed a test failure in DynamicBrokerReconfigurationTest where the test
> accessing `KafkaConfig#listeners` during dynamic update of listeners threw an
> exception. In general, most dynamic configs can be updated independently, but
> listeners and listener security protocol map need to be updated together when
> new listeners that are not in the map are added or an entry is removed from
> the map along with the listener. We don't expect to see this failure in the
> implementation code because dynamic config updates are on a single thread and
> SocketServer processes the full update together and validates the full config
> prior to applying the changes. But we should ensure that
> KafkaConfig#listeners, KafkaConfig#advertisedListeners etc. work even if a
> dynamic update occurs during the call since these methods are used in tests
> and could potentially be used in implementation code in future from different
> threads.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
