eduwercamacaro commented on code in PR #20955:
URL: https://github.com/apache/kafka/pull/20955#discussion_r2764534194


##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractReadWriteDecorator.java:
##########
@@ -48,6 +50,11 @@ public void init(final StateStoreContext stateStoreContext,
         throw new UnsupportedOperationException(ERROR_MESSAGE);
     }
 
+    @Override
+    public void commit(final Map<TopicPartition, Long> changelogOffsets) {

Review Comment:
   @nicktelford I just noticed that this integration test is broken: 
`org.apache.kafka.streams.integration.StandbyTaskEOSIntegrationTest.shouldWipeOutStandbyStateDirectoryIfCheckpointIsMissing`
   
   I think you need to override the `commit()` method on the 
`KeyValueStoreReadWriteDecorator` inner class and delegate the call to the 
wrapped store. That class is defined here on the line 81.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to