chia7712 commented on code in PR #21387:
URL: https://github.com/apache/kafka/pull/21387#discussion_r2765326248
##########
clients/src/test/java/org/apache/kafka/common/config/ConfigDefTest.java:
##########
@@ -616,7 +616,10 @@ public void testConvertValueToStringLong() {
@Test
public void testConvertValueToStringDouble() {
- assertEquals("3.125", ConfigDef.convertToString(3.125, Type.DOUBLE));
+ assertEquals("3.125", ConfigDef.convertToString(3.125d, Type.DOUBLE));
+ assertEquals("1.7976931348623157E308",
ConfigDef.convertToString(Double.MAX_VALUE, Type.DOUBLE));
+ assertEquals("1.024E8", ConfigDef.convertToString(102400000d,
Type.DOUBLE));
+ assertEquals("-1.024E8", ConfigDef.convertToString(-102400000d,
Type.DOUBLE));
assertNull(ConfigDef.convertToString(null, Type.DOUBLE));
Review Comment:
I just realized we don't have a test for `type=null`. we'll file a patch to
add it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
