mjsax commented on code in PR #21433:
URL: https://github.com/apache/kafka/pull/21433#discussion_r2785059538
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##########
@@ -1879,6 +1879,9 @@ private void completeShutdown(final boolean cleanRun) {
try {
final GroupMembershipOperation membershipOperation =
leaveGroupRequested.get() ==
org.apache.kafka.streams.CloseOptions.GroupMembershipOperation.LEAVE_GROUP ?
LEAVE_GROUP : REMAIN_IN_GROUP;
+ if (membershipOperation == REMAIN_IN_GROUP &&
streamsRebalanceData.isPresent()) {
Review Comment:
Not 100% sure about re-using `streamsRebalanceData.isPresent()` -- Sure it
works, but is it "clean"?
Should we rather introduce a member-variable (eg `GroupProtocol
rebalanceProtocol`)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
