chia7712 commented on code in PR #21379:
URL: https://github.com/apache/kafka/pull/21379#discussion_r2785102395
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/Cleaner.java:
##########
@@ -60,6 +61,11 @@ public class Cleaner {
private final Time time;
private final Consumer<TopicPartition> checkDone;
+ /**
+ * The topic partitions that have segment overflow history mapped to their
segment size ratio
+ */
+ private final Map<TopicPartition, Double> segmentOverflowPartitions = new
HashMap<>();
Review Comment:
If we cache overflowed partitions at the `Cleaner` level, they won't be
visible to other cleaners. This means another cleaner might hit the same error.
I think it's better to maintain this state in `LogCleaner`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
