aliehsaeedii commented on code in PR #21455:
URL: https://github.com/apache/kafka/pull/21455#discussion_r2832941657
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBKeyValueBytesStoreSupplier.java:
##########
@@ -24,11 +24,14 @@ public class RocksDBKeyValueBytesStoreSupplier implements
KeyValueBytesStoreSupp
private final String name;
private final boolean returnTimestampedStore;
+ private final boolean returnHeadersStore;
public RocksDBKeyValueBytesStoreSupplier(final String name,
- final boolean
returnTimestampedStore) {
+ final boolean
returnTimestampedStore,
+ final boolean returnHeadersStore)
{
this.name = name;
this.returnTimestampedStore = returnTimestampedStore;
+ this.returnHeadersStore = returnHeadersStore;
Review Comment:
Due to the first `else`, the 4th combination (both `true`) is served with
the first `if` which sematically is not wrong as headers stores are both ts and
are `WithHeaders`. No idea if considerinf 4th combination helps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
