chia7712 commented on code in PR #21551:
URL: https://github.com/apache/kafka/pull/21551#discussion_r2847018517
##########
docs/streams/upgrade-guide.md:
##########
@@ -78,7 +78,7 @@ please refer to the [developer
guide](/{version}/documentation/streams/developer
### Other changes
-Kafka Streams now supports Dead Letter Queue (DLQ). A new config
`errors.deadletterqueue.topic.name` allows to specify the name of the DLQ
topic. When set and `DefaultProductionExceptionHandler` is used, records that
cause exceptions will be forwarded to the DLQ topic. If a custom exception
handler is used, it is up to the custom handler to build DLQ records to send,
hence, depending on the implementation, the `errors.deadletterqueue.topic.name`
configuration may be ignored.
`org.apache.kafka.streams.errors.ProductionExceptionHandler$ProductionExceptionHandlerResponse`
is deprecated and replaced by
`org.apache.kafka.streams.errors.ProductionExceptionHandler$Response`. Methods
`handle` and `handleSerializationException` in
`org.apache.kafka.streams.errors.ProductionExceptionHandler` are deprecated and
replaced by `handleError` and `handleSerializationError` respectively in order
to use the new `Response` class. More details can be found in
[KIP-1034](https://cwiki.apache.org/confluen
ce/x/HwviEQ).
+Kafka Streams now supports Dead Letter Queue (DLQ). A new config
`errors.dead.letter.queue.topic.name` allows to specify the name of the DLQ
topic. When set and `DefaultProductionExceptionHandler` is used, records that
cause exceptions will be forwarded to the DLQ topic. If a custom exception
handler is used, it is up to the custom handler to build DLQ records to send,
hence, depending on the implementation, the
`errors.dead.letter.queue.topic.name` configuration may be ignored.
`org.apache.kafka.streams.errors.ProductionExceptionHandler$ProductionExceptionHandlerResponse`
is deprecated and replaced by
`org.apache.kafka.streams.errors.ProductionExceptionHandler$Response`. Methods
`handle` and `handleSerializationException` in
`org.apache.kafka.streams.errors.ProductionExceptionHandler` are deprecated and
replaced by `handleError` and `handleSerializationError` respectively in order
to use the new `Response` class. More details can be found in
[KIP-1034](https://cwiki.apache.org/conf
luence/x/HwviEQ).
Review Comment:
nice find. I have updated KIP as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
