chickenchickenlove commented on PR #21603: URL: https://github.com/apache/kafka/pull/21603#issuecomment-3976726254
@m1a2st , Hi! I’m currently working on implementing KAFKA-20169, which adds Static Membership support for StreamsGroup. During the client-side work, I realized I had to implement part of what’s being discussed in [KIP-1284](https://cwiki.apache.org/confluence/display/KAFKA/KIP-1284+Introduce+CloseOptions.DEFAULT+for+Kafka+Streams). Specifically, for static members, the client should be able to leave with epoch `-2`, but at the moment it always leaves with `-1`. Because of that, I had to adjust a portion of the code related to `close(CloseOptions)`. To complete this PR, I think there are a couple of possible approaches: - I can remove the `CloseOptions`-related changes from this PR and keep it focused only on the `group.instance.id` / static membership parts. If leaving with epoch `-2` is needed for integration tests, I could rebase and add it later after KIP-1284 is implemented. - Alternatively, I can include a partial implementation of the `CloseOptions` changes in this PR, and you could follow up with the remaining parts based on the direction you prefer for KIP-1284. I want to be respectful of the PR that will come out of KIP-1284. If you could let me know which direction you’d prefer, I’m happy to align with that. And if there’s a better approach than the options above, I’m very open to suggestions! Thanks in advance for your guidance. 🙇♂️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
